-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoGen Studio] Fix the new workflow process #1181
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this bug and suggesting a fix.
This PR makes changes to the convention used across multiple files (e.g., setWorkflow being renamed to saveWorflow).
Please consider limiting the change to removing setWorkflow(null)
. We can create a separate PR towards a general style refactor.
Thank you for your advice! The
|
83ef5dd
to
96759ed
Compare
@victordibia PTAL, thanks! |
96759ed
to
a2d874f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
=======================================
Coverage 32.08% 32.08%
=======================================
Files 32 32
Lines 4394 4394
Branches 1025 1025
=======================================
Hits 1410 1410
Misses 2867 2867
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Victor Dibia <victordibia@microsoft.com>
Co-authored-by: Victor Dibia <victordibia@microsoft.com>
Why are these changes needed?
Because the new workflow state is set to null, we are unable to add a new workflow again after editing or closing the workflow modal.
Before:
Screen.Recording.2024-01-09.at.16.16.08.mov
After:
Screen.Recording.2024-01-09.at.16.17.47.mov
Checks